Fixed http output code 404 although the node is reserved #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-caro
reviewed
Jun 6, 2017
| @@ -39,7 +39,7 @@ def reserve | |||
| respond_to do |format| | |||
| format.json { render :json => @hosts } | |||
| format.yaml { render :text => @hosts.to_yaml } | |||
| format.html { not_found } | |||
| format.html { render :json => hosts } | |||
There was a problem hiding this comment.
Hi David,
unfortunately I don't have any clue about Ruby prog. language. I don't know what semantics change means @hosts instead of hosts. My guess comes from other outcomes (other methods implemented there) from reserves_controller.rb.
I can see there that there is a mixture of either hosts or @hosts, from quick search I understand that @hosts is an instance variable under self, but in that case I don't understand if method reserve is correctly implemented too.
Do you know what is correct in this case?
Thank you, Pavel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the reported issue #6